Update espressif dependencies for ESP32-P4 and ESP32-H2 compatibility#67
Update espressif dependencies for ESP32-P4 and ESP32-H2 compatibility#67pham-tuan-binh wants to merge 2 commits intolivekit:mainfrom
Conversation
|
|
📝 WalkthroughWalkthroughUpdated IDF component dependency configuration to broaden platform support. The Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@components/livekit/examples/minimal_video/main/idf_component.yml`:
- Around line 13-15: Update the top comment in idf_component.yml that currently
references only "ESP32-P4-based development board" to include "ESP32-H2" as well
(e.g., "ESP32-P4- and ESP32-H2-based development boards") so the guidance
applies to both targets; edit the comment block shown in the diff to mention
"ESP32-H2" alongside "ESP32-P4" and keep the rest of the explanatory text
unchanged.
🧹 Nitpick comments (1)
components/livekit/examples/minimal_video/main/idf_component.yml (1)
20-22:esp_hostedhas no version constraint — consider adding one for reproducibility.
esp_wifi_remoteis correctly bounded with">=0.10,<2.0", butesp_hostedis completely unpinned. A future major-version bump could silently break builds. Adding a version range (similar toesp_wifi_remote) would keep builds reproducible while still allowing compatible updates.📌 Suggested fix
espressif/esp_hosted: + version: ">=0.5,<2.0" rules: - if: "target in [esp32p4, esp32h2]"(Adjust the lower bound to match the minimum version you've tested against.)
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/livekit/examples/minimal_video/main/idf_component.yml
🧰 Additional context used
📓 Path-based instructions (2)
components/**
📄 CodeRabbit inference engine (AGENTS.md)
Place LiveKit ESP32 SDK sources and supporting components in the
components/directory
Files:
components/livekit/examples/minimal_video/main/idf_component.yml
components/livekit/examples/**
📄 CodeRabbit inference engine (AGENTS.md)
Place example applications in
components/livekit/examples/directory
Files:
components/livekit/examples/minimal_video/main/idf_component.yml
🧠 Learnings (1)
📚 Learning: 2026-01-31T02:18:39.165Z
Learnt from: CR
Repo: livekit/client-sdk-esp32 PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-31T02:18:39.165Z
Learning: Applies to components/** : Place LiveKit ESP32 SDK sources and supporting components in the `components/` directory
Applied to files:
components/livekit/examples/minimal_video/main/idf_component.yml
🔇 Additional comments (1)
components/livekit/examples/minimal_video/main/idf_component.yml (1)
16-22: No issues found. Thetarget in [esp32p4, esp32h2]syntax and version constraint>=0.10,<2.0are valid according to ESP-IDF component manager documentation. The rules block correctly specifies conditional dependency inclusion for the specified targets.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
components/livekit/examples/minimal_video/main/idf_component.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2 participants
On newer ESP32-P4 devkits, the esp32 c6 slave come with a higher firmware version, which isn't compatible with current dependencies.
This updates the dependencies so the example can be compatible in such cases.